Cache implementation #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

aashishpatil-g wants to merge 40 commits into main from ap/coreSdkCacheV1

Collaborator

aashishpatil-g commented Nov 11, 2025

Implement caching in base (core) SDK

For googlers, refer to the doc go/fdc-sdk-caching

aashishpatil-g added 25 commits

October 29, 2025 09:19


          Initial Stub Classes

7c92921


          Wire up Initialization of CacheProvider

f56a8cc


          query level caching

f655a15

TODO - needs cleanup


          Cache Normalization Implementation

90c7ae1


          Persistent Provider

5174e03


           Add last_accessed field

ad71e3c


          Uber Cache object, support Auth uid scope and Refactor classes

c0a024b


          Implement operationId on QueryRef

0bcdf09


          Fix sha256 formatter.

ad749e7


          Accumulate Impacted Refs and Reload Local

35dc280


          Update construction of cacheIdentifier to include connector and locat…

6cd60ef

…ion info


          Use inmemory SQLite for Ephemeral cache provider

824a41e


          Minor updates to API

f503f5e


          Refactor BackingDataObject, STubDataObject names to EntityDataObject …

e57bbb4

…and EntityNode


          DispatchQueue for EntityDataObject access

353caf5


          Externalize table and column name strings into constants

78599a3


          API Review feedback

250e905


          Code formatting updates

f1aa717


          Refactor name of OperationResultSource

d9b4807


          API feedback - rename maxSize => maxSizeBytes

1c666ec


          API Council Review Feedback

8ea6762


          Move ServerResponse

a807d9f


          Update cache type to match API review feedback

336e41b


          Cleanup and minor fixes to docs

37493c4


          Update globalID value

dd8569c

aashishpatil-g requested review from dconeybe, maneesht, ncooke3 and stephenarosaj

November 11, 2025 19:36

Collaborator

dconeybe commented Nov 12, 2025

/gemini review

ncooke3 reviewed

View reviewed changes

Sources/Queries/ObservableQueryRef.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Queries/ObservableQueryRef.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Queries/ObservableQueryRef.swift Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Queries/GenericQueryRef.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Queries/GenericQueryRef.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Queries/GenericQueryRef.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Internal/OperationsManager.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/DataConnect.swift Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/CacheSettings.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/ResultTree.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/ResultTree.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/ResultTree.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/ResultTreeProcessor.swift Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/ResultTreeProcessor.swift Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/ResultTreeProcessor.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/EntityDataObject.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/ResultTreeProcessor.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/SQLiteCacheProvider.swift Outdated Show resolved Hide resolved

ncooke3 reviewed

View reviewed changes

Sources/Cache/SQLiteCacheProvider.swift Show resolved Hide resolved

Member

ncooke3 commented Nov 18, 2025

@aashishpatil-g, left a first pass!

aashishpatil-g added 6 commits

November 18, 2025 15:52


          Nick feedback

517fdcd


          Remove unnecessary custom codable in EDO

b9265dc


          Convert data connect to a weak reference in cache

6689c9c


          formatting fixes

2b90b52


          Doc comments for Settings

edfcd83


          Incorporate maxAge

aashishpatil-g requested a review from ncooke3

December 3, 2025 19:34

ncooke3 approved these changes

View reviewed changes

ncooke3 reviewed

View reviewed changes

Sources/Cache/CacheSettings.swift Outdated Show resolved Hide resolved


          Nick feedback. Update doc comments on CacheSettings.maxAge

ba3b894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncooke3 ncooke3 approved these changes

maneesht Awaiting requested review from maneesht

dconeybe Awaiting requested review from dconeybe

stephenarosaj Awaiting requested review from stephenarosaj

+1 more reviewer

gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Labels

None yet